Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tag): retire unused tag queries and previous deprecated #4217

Merged
merged 7 commits into from
Nov 18, 2024

Conversation

gitwoz
Copy link
Contributor

@gitwoz gitwoz commented Nov 7, 2024

  • retire tag management features;
  • retire previous deprecated queries;

@gitwoz gitwoz requested a review from a team as a code owner November 7, 2024 08:49
@gitwoz gitwoz linked an issue Nov 7, 2024 that may be closed by this pull request
3 tasks
@robertu7 robertu7 force-pushed the feat/deprecate-tag-management branch 2 times, most recently from 8c03711 to 68986d1 Compare November 7, 2024 09:50
@robertu7 robertu7 force-pushed the feat/deprecate-tag-management branch from 0999968 to c358fdd Compare November 7, 2024 12:09
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 54.54545% with 40 lines in your changes missing coverage. Please review.

Project coverage is 61.55%. Comparing base (7359cef) to head (908770f).
Report is 9 commits behind head on develop.

Files with missing lines Patch % Lines
src/connectors/tagService.ts 33.33% 20 Missing and 2 partials ⚠️
src/queries/article/tag/articles.ts 0.00% 8 Missing ⚠️
src/queries/article/tag/recommendedAuthors.ts 42.85% 3 Missing and 1 partial ⚠️
src/queries/article/bookmarked.ts 33.33% 2 Missing ⚠️
...migrations/20241112112619_create_tag_stats_view.js 83.33% 1 Missing ⚠️
...ations/20241112165500_create_article_stats_view.js 80.00% 1 Missing ⚠️
...grations/20241113094622_create_tag_hottest_view.js 80.00% 1 Missing ⚠️
src/mutations/article/editArticle.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4217      +/-   ##
===========================================
+ Coverage    60.51%   61.55%   +1.04%     
===========================================
  Files          958      936      -22     
  Lines        18920    18264     -656     
  Branches      3517     3336     -181     
===========================================
- Hits         11449    11243     -206     
+ Misses        6751     6366     -385     
+ Partials       720      655      -65     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gitwoz gitwoz merged commit 38151d1 into develop Nov 18, 2024
4 of 5 checks passed
@delete-merged-branch delete-merged-branch bot deleted the feat/deprecate-tag-management branch November 18, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Retire tag management features
3 participants