Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tock Studio] Angular version upgrade (v14 to v17) #1710

Merged
merged 13 commits into from
Aug 7, 2024
Merged

[Tock Studio] Angular version upgrade (v14 to v17) #1710

merged 13 commits into from
Aug 7, 2024

Conversation

rkuffer
Copy link
Contributor

@rkuffer rkuffer commented Aug 5, 2024 •
edited
Loading

Problems encountered:

@rkuffer rkuffer linked an issue Aug 5, 2024 that may be closed by this pull request
[Tock Studio] Angular version upgrade #1712
Closed
@rkuffer rkuffer marked this pull request as ready for review August 5, 2024 12:28
@rkuffer rkuffer requested a review from Benvii August 5, 2024 12:28
Benvii
Benvii approved these changes Aug 5, 2024
View reviewed changes
Copy link
Member

@Benvii Benvii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me, just one comment about the chart component.

bot/admin/web/src/app/analytics/flow/flow.component.html Show resolved Hide resolved
bot/admin/web/src/app/analytics/flow/flow.component.ts Show resolved Hide resolved
bot/admin/web/src/app/applications/applications.module.ts Show resolved Hide resolved
@Benvii Benvii mentioned this pull request Aug 6, 2024
Closed
@Benvii Benvii merged commit 6a8a5e7 into theopenconversationkit:master Aug 7, 2024
@Benvii Benvii deleted the Angular-version-upgrade branch August 7, 2024 07:37
@vsct-jburet vsct-jburet added this to the 24.3.5 milestone Aug 20, 2024
morgandiverrez pushed a commit that referenced this pull request Aug 26, 2024
@rkuffer
[Tock Studio] Angular version upgrade (v14 to v17) (#1710)
707e3a7 
* Temporarily remove angular-eslint devDep

* Upgrade v14 to v15

* npm update

* Upgrade zone.js to v0.13

* Update typescript to v4.9.5

* Update eslint to v 16.2.14

* Temporarily remove angular-eslint devDep

* Upgrade v15 to v16

* typescript and zone.js upgrade

* Remove angular-eslint

* Upgrade v16 to v17

* Temp workaround for incompatibility of Nebular 13 vith angular cdk >17.1

* Upgrade Cytoscape

Fixes #1712
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AurelienSylvan AurelienSylvan AurelienSylvan approved these changes

@Benvii Benvii Benvii approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
24.3.5
Development

Successfully merging this pull request may close these issues.

[Tock Studio] Angular version upgrade
4 participants
@rkuffer @Benvii @AurelienSylvan @vsct-jburet