Implement Output Sanitizer to Enhance Security and Data Integrity #1774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi-2r
force-pushed
the
output_sanitizer
branch
from
8ea6a69 to
8e5c88b
Compare
pi-2r
force-pushed
the
output_sanitizer
branch
from
8e5c88b to
941e545
Compare
added 2 commits
November 12, 2024 21:24
|
Hi Pierre, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new
safeHTMLfunction to sanitize user inputs and prevent XSS attacks. The changes span multiple files and include updates to processing logic, utility functions, and unit tests.XSS Prevention and HTML Sanitization:
BotAdminService.kt: Updated to usesafeHTMLfor sanitizing request labels.WebConnector.kt: Added a newprocessSafeHtmlproperty toWebMessageProcessorto enable safe HTML processing.WebMessageProcessor.kt: Modified to incorporatesafeHTMLin text post-processing, ensuring both Markdown and HTML safety. [1] [2]Strings.kt: IntroducedsafeHTMLfunction and supporting utilities to escape and filter unsafe HTML content. [1] [2]Unit Tests:
StringsTest.kt: Added comprehensive unit tests forsafeHTMLto validate its effectiveness against various XSS attack vectors and ensure proper functionality.