feat: otp recovery code defaults (#138)

* feat: align defaults with config default Signed-off-by: Sarah Funkhouser <[email protected]> * remove log Signed-off-by: Sarah Funkhouser <[email protected]> --------- Signed-off-by: Sarah Funkhouser <[email protected]>
theopenlane · Jan 27, 2025 · 4ded220 · 4ded220
1 parent c17eada
commit 4ded220
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/totp/config.go b/totp/config.go
@@ -3,7 +3,7 @@ package totp
 const (
 	defaultLength             = 6
 	defaultRecoveryCodeCount  = 16
-	defaultRecoveryCodeLength = 10
+	defaultRecoveryCodeLength = 8
 	codePeriod                = 30
 )
 

diff --git a/totp/totp.go b/totp/totp.go
@@ -384,8 +384,7 @@ func GenerateOTP(secret string) (string, error) {
 func (o *OTP) GenerateRecoveryCodes() []string {
 	codes := []string{}
 
-	// for range o.recoveryCodeCount { // this works in go 1.22 but the linter barfs while its still on 1.21
-	for i := 1; i <= o.recoveryCodeCount; i++ {
+	for range o.recoveryCodeCount {
 		code, err := String(o.recoveryCodeLength, alphanumericCode)
 		if err != nil {
 			continue