Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump deps to remove sass in favor of sassc #67

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

L1ghtmann
Copy link
Member

What does this implement/fix? Explain your changes.

  • See title

Does this close any currently open issues?

Any relevant logs, error output, etc?

Any other comments?

  • Currently fails with
sprockets-4.2.1/lib/sprockets/path_utils.rb:111:in `initialize': no implicit conversion of nil into String (TypeError)

      start, dest = Pathname.new(start), Pathname.new(dest)

which I think is because I'm using WSL? Pr'ing now to test ....

Where has this been tested?

Operating System:

Linux (WSL)

Platform:

Target Platform:

Toolchain Version:

SDK Version:

Copy link

netlify bot commented Jul 7, 2024

Deploy Preview for theos-site failed.

Built without sensitive environment variables

Name Link
🔨 Latest commit f2244d8
🔍 Latest deploy log https://app.netlify.com/sites/theos-site/deploys/668af0e221664a0008b3c35a

@L1ghtmann
Copy link
Member Author

Note to self: the root issue seems to spawn from jekyll-assets being borked and unmaintained. Specifically, it looks like v4 of sprockets dependency changed core behavior of something, causing build issues.

sprockets < 4.0.0 works for theos.dev's build but doesn't allow for the newer jekyll-assets. This is problematic as the newer version of one of these (forgetting which now ... whoops) does away with the sass dependency, which looks to have caused the Netlify build to fail, in favor of sassc.

Current attempts at resolving without modifying our source are present at https://github.com/L1ghtmann/jekyll-assets. Not sure how feasible trying to maintain support for an old, complex gem is.

Relevant ref commit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant