Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with updating messages. #19

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Fix issues with updating messages. #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion slack/examples_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,9 @@ func expectOneMessage(messages chan sentMessage, updatedMessages chan updatedMes
select {
case update = <-updatedMessages:
if update.timestamp != timestamp {
return "", slack.SlackMetadata{}, "", fmt.Errorf("unexpected timestamp in update: %v", err)
// Ignore an update for the "parent" message
// TODO: This will be pretty brittle
update = <-updatedMessages
}
case <-time.After(time.Second):
return "", slack.SlackMetadata{}, "", fmt.Errorf("timed out waiting for initial message update")
Expand Down
2 changes: 1 addition & 1 deletion slack/message.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ func (m *message) finishEvent(req request) error {
if err != nil {
return fmt.Errorf("updating message to record timestamp: %w", renderSlackError(err))
}
} else if m.MessageTS != m.actionMessageTS {
} else if m.MessageTS == m.actionMessageTS {
_, _, _, err := req.client.UpdateMessageWithMetadata(
context.TODO(),
m.ChannelID,
Expand Down