Update dependencies and fix BC accordingly #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Support for league/uri 7.x
I sent it: |
|
@scaytrase |
|
The support for The issue I mentioned at the beginning, about not being able to install this library in recent frameworks, is now completely resolved. |
|
@scaytrase If there's anything I can do to help, please let me know. I'll be happy to do it. |
scaytrase
reviewed
Jan 10, 2024
| @@ -12,6 +12,8 @@ class StringURI | |||
| public function __invoke(string $value): bool | |||
| { | |||
| try { | |||
| // namespace 'League\Uri' is provided by multiple packages, but PHPStan does not support merging them | |||
| // @phpstan-ignore-next-line | |||
There was a problem hiding this comment.
I think this one could be reported to phpstan. really strange
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This package has slightly older dependencies, making it a little more difficult to install on frameworks including Laravel and Symfony. (For example, currently, the
-woption is required forcomposer requirebecausepsr/http-messageneeds to be downgraded during installation.)To address these issues, I have expanded or updated the versions of some of the most frequently used packages.
psr/http-messageleague/uriSuppress errors caused by version changes in
league/uriguzzlehttp/psr7^2.0.^2.0contains breaking changes, so I have fixed all code related to them. Details of the fixes are described here. I simply replaced the method.UPDATE: 2024-01-08 13:30 UTC
psr/http-messagepsr/http-message:^2.0and updating dependencies hansott/psr7-cookies#17Additional Information
I previously created a pull request in #215 that significantly expanded the scope of CI. Although it has not been merged yet, I have tested this pull request with that commit in my repository.
In addition to the PHP versions supported by the current CI, we can confirm that the tests pass on recent PHP versions, including the latest version. The results can be viewed here.
Note
Please note that even after importing this pull request,psr/http-messagewill not be upgraded to2.0due to other packages requiring version1.0.I am also planning to submit a pull request to the repository of that package to address this issue.UPDATE: 2024-01-08 13:30 UTC
That pull request is accepted and published as
4.0, so I updated this pull request to follow it.