Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nullable: false validation #226

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

leNEKO
Copy link

@leNEKO leNEKO commented May 2, 2024

Context

(See this issue #227)

For some reason nullable is implicitly true (see https://github.com/thephpleague/openapi-psr7-validator/pull/155/files#r1587568801)

But trying to validate an explicitly"nullable": false property will crash with a TypeError instead of throwing an InvalidBody Exception.

Modification

  • checking if the $this->parentSchema->type is a proper array instead of checking if it is not a string
  • adding a non-regression test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant