Skip to content
This repository has been archived by the owner on Jun 20, 2021. It is now read-only.

Added more blocks to the List module #39

Merged
merged 2 commits into from
Oct 9, 2018

Conversation

Youngestdev
Copy link
Contributor

Description

Added the .last() and .first() block.

Please include the summary of the changes and which issue is fixed. Also, list relevant contexts, dependencies that are requested for this change.

The added blocks, executes the following tasks:

  • .last() - Returns the last element in the specified List.
  • .first() - Returns the first element in the specified List.

Fixes issue #( #15 )

Type Of Change

Feature

Please delete options that are not relevant and mark the ones that are relevant.

  • New feature: Non breaking change which adds a new functionality ( module, environment etc).

Briefly Explain Why This PR Should Be Merged.

This PR should be merged so that the new features can be executed and can be employed.

How Has This Been Tested ?

Creating a new list and return values from the added blocks.

Please describe how you ran the test after effecting your changes. Also, add snapshots or screenshots of the working change as proof-of-work.

I tested this changes as follows:

  1. I opened the simplerepl enviroment.
  2. Called the List module
  3. Created a new List and entered some values.
  4. Return both the first and last values.

Screenshot - Proof-of-work

Checklist:

  • I have created a supporting issue for this PR.
  • [x ] My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests passed locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Thecarisma Thecarisma self-assigned this Oct 9, 2018
@Thecarisma
Copy link
Contributor

I ll review the changes now

@Thecarisma Thecarisma merged commit 49b70c2 into theratioproject:master Oct 9, 2018
@Thecarisma Thecarisma added this to the 0.4.0 milestone Oct 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants