Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting duplicates in component list #21

Open
vegardjervell opened this issue Dec 13, 2022 · 0 comments
Open

Supporting duplicates in component list #21

vegardjervell opened this issue Dec 13, 2022 · 0 comments

Comments

@vegardjervell
Copy link
Collaborator

First of all: This is not a major issue, but (at most) a minor annoyance that takes 5 lines of code to work around. If it requires more than very little time to fix, it's probably not worth it.

With that said:
At times I find myself wanting to model e.g. a LJ-mixture with some sigma-ratio or similar. Until now, I have solved this by for example initialising saftvrmie with two components that are fairly similar (e.g. AR/KR) and then using set_pure_fluid_param() and get_pure_fluid_param() to change the fluid parameters. However, it would be nice to be able to just initialise with LJF/LJF, and then set_pure_fluid_param(), thus saving the time spent extracting parameters for one component, scaling them, and then setting parameters for the other component.

I don't know exactly how the parameter sets are handled on the fortran-side, so this might be non-trivial to support, I'm just throwing it out as a suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant