[SKIP SOF-TEST] .github: re-enable rimage workflows #8328
Conversation
We already have these checks in sof.git so they don't need to be migrated. Signed-off-by: Marc Herbert <[email protected]>
marc-hb
force-pushed
the
github-rimage
branch
7 times, most recently
from
bf56e6c to
0d75f46
Compare
Migrate rimage build and cppcheck workflows from sof/tools/rimage/.github/workflows/ (where they're ignored) to sof/.github/workflows/ Signed-off-by: Marc Herbert <[email protected]>
marc-hb
force-pushed
the
github-rimage
branch
from
0d75f46 to
fe2bc02
Compare
marc-hb
requested review from
dbaluta,
cujomalainey,
lgirdwood,
plbossart,
mmaka1,
lbetlej and
kv2019i
as code owners
marc-hb
requested review from
dcpleung,
aiChaoSONG,
softwarecki,
LaurentiuM1234,
iuliana-prodan,
RanderWang and
pjdobrowolski
|
Note I had to disable "If it's not tested then it does not work" - applies to every test, check and even CFLAGS. |
| # FIXME: add -Wpointer-arith | ||
| _CFLGS: -Werror -Wall -Wmissing-prototypes | ||
| -Wimplicit-fallthrough=3 | ||
|
|
There was a problem hiding this comment.
Can we also have build target for windows?
There was a problem hiding this comment.
That would be great but I have no idea what it would take and I don't have any Windows system right now.
I can help with the Github Actions aspects if you want to try to add it later. For now this PR is merely trying to restore lost functionality.
There was a problem hiding this comment.
Here is recipe for windows:
export OPENSSL_PATH="c:/msys64/var/lib/pacman/local/openssl-1.1.1.n-1"
export CAT_PATH="c:/Program Files/Git/usr/bin"
export NINJA_PATH="c:/Program/ Files/ninja"
export MSYS_INSTALL_DIR="C:/msys64/usr/bin/"
export CMAKE_GENERATOR=Ninja
cmake -B zephyrproject/build-rimage -S zephyrproject/sof/rimage
cmake --build zephyrproject/build-rimage
Some of us are windows users and it would be nice if building would be checked for them...
Maybe open issue with that and leave it for future development?
There was a problem hiding this comment.
Some of us are windows users and it would be nice if building would be checked for them...
Absolutely yes of course. But let's please first restore previous functionality and make sure rimage compiles without warning on ANYTHING :-)
export OPENSSL_PATH="c:/msys64/var/lib/pacman/local/openssl-1.1.1.n-1"
...
I doubt this will all work with Github's Windows image but we can probably re-use some of df1ba22
Maybe open issue with that and leave it for future development?
Depends on how long it takes, it could be quick (famous last words) and not really require a new issue.
There was a problem hiding this comment.
I doubt this will all work with Github's Windows image but we can probably re-use some of df1ba22
Wait: this commit already compiles rimage on Windows (without -Werr -Wall). It's a bit lost in the long build logs but it's there. So unless you recommend a different toolchain (which one?) with a different set of warnings maybe then adding Windows here too wouldn't give anything new?
There was a problem hiding this comment.
unless it will not change in the future then I don't see any problems.
Migrate rimage build and cppcheck workflows from
sof/tools/rimage/.github/workflows/ (where they're ignored) to sof/.github/workflows/
cc: