Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dates in competitions admin view #10682

Merged
merged 3 commits into from
Jan 28, 2025
Merged

Fix dates in competitions admin view #10682

merged 3 commits into from
Jan 28, 2025

Conversation

maxidragon
Copy link
Member

@maxidragon maxidragon commented Jan 22, 2025 •
edited by kr-matthews
Loading

Fixes second medium sub-task from #10596

In Admin View, "Results submitted" date always shows pending, even when results have been posted

@maxidragon maxidragon force-pushed the competitions-admin-dates branch from 55eefa9 to 62943df Compare January 22, 2025 12:25
@kr-matthews kr-matthews mentioned this pull request Jan 18, 2025
Open
5 tasks
gregorbg
gregorbg approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@gregorbg gregorbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took the liberty of slimming down the serialization a bit, otherwise LGTM 🐱

@gregorbg gregorbg merged commit d4efb2c into thewca:main Jan 28, 2025
2 checks passed
@maxidragon maxidragon deleted the competitions-admin-dates branch January 28, 2025 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregorbg gregorbg gregorbg approved these changes

Assignees

@maxidragon maxidragon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxidragon @gregorbg