Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Node.traverse() to allow custom graph traversals. #103

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dkushner
Copy link

This PR implements the Node.traverse() method, satisfying #102. Total test coverage is forthcoming and it currently does not check for the 'fullpath' return type since that doesn't seem to be supported anywhere else in the API.

@aseemk
Copy link
Member

aseemk commented Feb 2, 2014

Thanks for submitting this, @dkushner! Just to clarify, test coverage was added, right? Is there any more you plan to add to this PR?

@aseemk
Copy link
Member

aseemk commented Feb 2, 2014

Btw, you're correct that fullpath return types aren't supported anywhere else in the API:

https://github.com/thingdom/node-neo4j/blob/1.1.0/lib/util.coffee#L151-L152

This is because Cypher's PATH doesn't return fullpath, so aside from this traverse method, there's nothing else that needs it.

@aseemk
Copy link
Member

aseemk commented Feb 9, 2014

Sorry for the delay, @dkushner. The tests fail locally for me, do they fail for you too?

If you merge the latest master into your branch (or if you know git well, rebase your branch to the latest master) and re-push, Travis CI is properly configured now, so we can see whether they pass there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants