-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add analysis suite #3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good to me. I'd probably argue whitespace on some of it, but that's personal opinion, so I won't argue with what you got.
One recommendation: add to implicit usings using <Usings Include="" />
in the csproj instead of using GlobalUsings.cs.
var location = operation.Syntax is InvocationExpressionSyntax | ||
{ | ||
Expression: MemberAccessExpressionSyntax | ||
{ | ||
Name: GenericNameSyntax | ||
{ | ||
TypeArgumentList.Arguments: [var typeSyntax] | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love this
I didn't know you could do this. I might do a pr to clean this up later, although for now I prefer keeping them in a Usings.cs file. |
Adds a suite of analyzers and corresponding code fixes. Want to add more in the future but this works as a minimum.