Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply userop timeout based on client options #128

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Feb 12, 2025

PR-Codex overview

This PR introduces a cancellation mechanism for fetching the user operation receipt in the SmartWallet class, improving timeout handling and responsiveness.

Detailed summary

  • Replaced the initial while loop for fetching txHash with a using statement for CancellationTokenSource.
  • Added a try-catch block to handle OperationCanceledException.
  • Threw an exception with a message if the operation times out, instead of proceeding silently.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 72.70%. Comparing base (bee1518) to head (5179dd9).

Files with missing lines Patch % Lines
...irdweb/Thirdweb.Wallets/SmartWallet/SmartWallet.cs 75.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #128      +/-   ##
==========================================
- Coverage   72.82%   72.70%   -0.12%     
==========================================
  Files          34       34              
  Lines        5232     5239       +7     
  Branches      691      693       +2     
==========================================
- Hits         3810     3809       -1     
- Misses       1248     1254       +6     
- Partials      174      176       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@0xFirekeeper 0xFirekeeper merged commit 6b4afc1 into main Feb 12, 2025
3 checks passed
@0xFirekeeper 0xFirekeeper deleted the firekeeper/apply-userop-timeout branch February 12, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants