Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow login with tw auth token #129

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Conversation

0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Feb 12, 2025

Useful in case you have a launcher and already have a session there, similar to generating an external login link for react from .net

Closes TOOL-3405


PR-Codex overview

This PR introduces a new parameter, twAuthTokenOverride, to the Create methods in both EcosystemWallet and InAppWallet. This allows for session authentication using a raw thirdweb auth token.

Detailed summary

  • Added twAuthTokenOverride parameter to Create method in EcosystemWallet.cs.
  • Implemented logic to use twAuthTokenOverride in session creation within EcosystemWallet.
  • Added twAuthTokenOverride parameter to Create method in InAppWallet.cs.
  • Updated call to Create in InAppWallet to include twAuthTokenOverride.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Useful in case you have a launcher and already have a session there, similar to generating an external login link for react from .net

Closes TOOL-3405
Copy link

linear bot commented Feb 12, 2025

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.70%. Comparing base (6b4afc1) to head (51f2c91).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #129   +/-   ##
=======================================
  Coverage   72.70%   72.70%           
=======================================
  Files          34       34           
  Lines        5239     5239           
  Branches      693      693           
=======================================
  Hits         3809     3809           
  Misses       1254     1254           
  Partials      176      176           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@0xFirekeeper 0xFirekeeper merged commit 325625a into main Feb 13, 2025
3 checks passed
@0xFirekeeper 0xFirekeeper deleted the firekeeper/auth-token-login branch February 13, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants