Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modular Account (7579) #71

Closed
wants to merge 8 commits into from
Closed

Conversation

0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Sep 13, 2024

TODO: ModeLib, ExecLib, Session Keys


PR-Codex overview

The focus of this PR is to introduce Modular Smart Wallet functionality, including session key creation and chain-agnostic transactions.

Detailed summary

  • Added ModularSmartAccount to IThirdwebWallet
  • Implemented ExecuteModular and ExecuteChainAgnosticModular functions
  • Added IsChainAgnostic property to ThirdwebTransactionInput
  • Introduced SessionKeyParamsModular and related classes
  • Updated ModularSmartWallet with deployment logic and network switching functionality

The following files were skipped due to too many changes: Thirdweb/Thirdweb.Wallets/SmartWallet/ModularSmartWallet.cs, Thirdweb/Thirdweb.Utils/Constants.cs

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

TODO: ModeLib, ExecLib, Session Keys
@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 1.24069% with 398 lines in your changes missing coverage. Please review.

Project coverage is 78.60%. Comparing base (fd18d3d) to head (f9bd9b3).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...Thirdweb.Wallets/SmartWallet/ModularSmartWallet.cs 0.00% 384 Missing ⚠️
...SmartWallet/Thirdweb.AccountAbstraction/AATypes.cs 0.00% 11 Missing ⚠️
...rdweb/Thirdweb.Transactions/ThirdwebTransaction.cs 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #71      +/-   ##
==========================================
- Coverage   87.02%   78.60%   -8.43%     
==========================================
  Files          26       27       +1     
  Lines        3776     4187     +411     
  Branches      525      562      +37     
==========================================
+ Hits         3286     3291       +5     
- Misses        490      896     +406     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@0xFirekeeper 0xFirekeeper marked this pull request as draft November 21, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants