-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK] USD balance for AccountBalance #5533
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 7beaa25 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
packages/thirdweb/src/react/web/ui/prebuilt/Account/balance.tsx
Outdated
Show resolved
Hide resolved
size-limit report 📦
|
1bf3114
to
c2329af
Compare
Don't forget a changeset but lgtm |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## kien/pay-convert-endpoints #5533 +/- ##
=============================================================
Coverage ? 46.21%
=============================================================
Files ? 1086
Lines ? 58866
Branches ? 3951
=============================================================
Hits ? 27206
Misses ? 30977
Partials ? 683
*This pull request uses carry forward flags. Click here to find out more.
|
dcd6b94
to
07afcee
Compare
c2329af
to
4b66fbd
Compare
814a397
to
5f95189
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like you need to bump the cjs size limit, make it 120000?
f1e9de2
to
ac08a47
Compare
5f95189
to
b31951c
Compare
ac08a47
to
57fa96b
Compare
b31951c
to
ebfc761
Compare
ebfc761
to
7beaa25
Compare
CNCT-2494
PR-Codex overview
This PR focuses on exporting utility functions for number formatting and implementing them in the
AccountBalance
component to enhance balance display, including support for fiat values.Detailed summary
formatNumber
andshortenLargeNumber
utilities.shortenLargeNumber
.AccountBalance
to useformatNumber
andshortenLargeNumber
.formatFn
inAccountBalanceProps
to accept new parameters.