-
-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clicking image before image is loaded #9
Comments
Oooh, yeah, this is definitely a bug. It ties directly into #7's problem as well, where click events get a little bit messed up in the loading time. I think tomorrow, I'll create a full bug report containing all the fixes that need to happen (loader, and load screen, which would stop this potential double image click, as well as the load wait time) and them merge both #7 and #9 into it. Thanks so much for reporting! |
Since this is a small part of #10, I'm merging it in, and closing this branch of the issue. |
This is really great with image loaded with the data-image attribute and are very big. This fix the issue tholman#9
Avoid double click on a active lightbox tholman#9 and add classes on the element for styling during image loading tholman#10 I'm not a killer in simple javascript but with jQuery, so perhaps the code is not so compatible with classes ?
As the images are loading on the page before opening the intense modal, I clicked one. It didn't activate, so I clicked another image that was already full loaded and the modal launched as expected. Then, once the original image was full loaded, it activated a second modal over the one I was viewing. Clicking the 'X' closed the second modal, leaving the first one up. I could not close this one and had to refresh.
(On newest version of Chrome on OS X)
The text was updated successfully, but these errors were encountered: