-
-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
data-src image loading. #10
Comments
Is this fixed in the current version? I like your Script and I would like to use it on my photo-blog for fullscreen view. |
Same Question and issue. |
It isn't yet, no :( |
Avoid double click on a active lightbox tholman#9 and add classes on the element for styling during image loading tholman#10 I'm not a killer in simple javascript but with jQuery, so perhaps the code is not so compatible with classes ?
Is there any plan to fix this? I'm barely above noob level but will have a look at the source. Any tips for where I might look for callbacks, or where I should be adding one in? |
@bsehl this is fixed by adding state classes on the element (myconcretelab@c498df1) you are now able to add a spinner onto the images. Simply add a new css-rule to your stylesheets to get an loading animation, something like: .intense.loading::after {
background: rgba(255, 255, 255, 0.8) url("/image/loading.gif") no-repeat scroll center 170px;
bottom: 0;
content: "";
left: 0;
position: absolute;
right: 0;
top: 0;
} Demo: http://www.ingosfotoblog.de/2015/09/05/rote-dahlie-bei-uns-am-balkon/ (klick the large image) |
would love to have this fixed as well. will try the loading.gif as a preventive thing. |
How about having a callback option for
|
Also valid, I changed the way config works slightly. But this'd definitely be the way to go |
Right, so now it would be possible to attach a loader with both |
When loading an image with data-src, there is the potential to have a situation where the image isn't loaded already, which means there is a delay opening the image for viewing... within this delay, clicking around can confuse intense.js into thinking images are open when they aren't.
The fix: Add a small spinner, which will activate when the image isn't fully loaded, and will only really be on the screen while the image loads. Clicking the background while the spinner is open, will cancel the load, and hide intense straight away.
Merging in #7 and #9 into this issue, and closing them off as duplicates, as they are each small parts of the 1 issue.
The text was updated successfully, but these errors were encountered: