Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to use additional regex features (e.g. negative lookahead) #54

Merged
merged 8 commits into from
Dec 13, 2024

Conversation

thomasschafer
Copy link
Owner

@thomasschafer thomasschafer commented Dec 4, 2024

Allows users to use the fancy-regex (rather than regex) crate, which adds additional features like negative lookahead at the expense of speed. This can be enabled using the --advanced_regex (-a) CLI flag.

Resolves #44

To do:

  • Do some more manual testing
  • Add tests for advanced regex functionality

@thomasschafer thomasschafer changed the title Add --advanced-regex flag to use fancy_regex crate Add flag to use additional regex features (e.g. negative lookahead) Dec 4, 2024
@thomasschafer thomasschafer force-pushed the tschafer-add-select-all-key branch 2 times, most recently from 4db4cd1 to f790717 Compare December 10, 2024 19:24
@thomasschafer thomasschafer force-pushed the tschafer-add-select-all-key branch from 4165587 to 1fee027 Compare December 13, 2024 16:49
@thomasschafer thomasschafer marked this pull request as ready for review December 13, 2024 17:27
@thomasschafer thomasschafer merged commit 6309198 into main Dec 13, 2024
3 checks passed
@thomasschafer thomasschafer deleted the tschafer-add-select-all-key branch December 13, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support negative lookahead and similar
1 participant