Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove spring-boot-starters dependency on adapters and application modules #12

Draft
wants to merge 1 commit into
base: multi-module
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
HELP.md
.gradle
build/
bin/
!gradle/wrapper/gradle-wrapper.jar

### STS ###
Expand Down
8 changes: 3 additions & 5 deletions adapters/buckpal-persistence/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,9 @@ dependencies {
implementation project(':common')
implementation project(':buckpal-application')

compileOnly 'org.projectlombok:lombok'
annotationProcessor 'org.projectlombok:lombok'

implementation 'org.springframework.boot:spring-boot-starter-validation'
implementation 'org.springframework.boot:spring-boot-starter-data-jpa'
implementation('org.springframework.boot:spring-boot-starter-data-jpa') {
exclude(module: 'spring-boot-starter')
}

testImplementation('org.springframework.boot:spring-boot-starter-test') {
exclude group: 'junit' // excluding junit 4
Expand Down
8 changes: 3 additions & 5 deletions adapters/buckpal-web/build.gradle
Original file line number Diff line number Diff line change
@@ -1,12 +1,10 @@
dependencies {
implementation project(':common')
implementation project(':buckpal-application')

implementation 'org.springframework.boot:spring-boot-starter-web'

compileOnly 'org.projectlombok:lombok'
annotationProcessor 'org.projectlombok:lombok'

implementation 'org.springframework:spring-web'

testImplementation 'org.springframework.boot:spring-boot-starter-web'
testImplementation('org.springframework.boot:spring-boot-starter-test') {
exclude group: 'junit' // excluding junit 4
}
Expand Down
6 changes: 3 additions & 3 deletions buckpal-application/build.gradle
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
dependencies {
implementation project(':common')

compileOnly 'org.projectlombok:lombok'
annotationProcessor 'org.projectlombok:lombok'
implementation 'org.springframework:spring-context'

implementation 'org.springframework.boot:spring-boot-starter-validation'
implementation 'org.hibernate:hibernate-validator:6.1.3.Final'
implementation 'org.glassfish:javax.el:3.0.0'

implementation 'javax.transaction:javax.transaction-api'

Expand Down
6 changes: 1 addition & 5 deletions buckpal-configuration/build.gradle
Original file line number Diff line number Diff line change
@@ -1,12 +1,8 @@
plugins {
id "org.springframework.boot" version "2.1.9.RELEASE"
id "org.springframework.boot" version "2.2.6.RELEASE"
}

dependencies {

compileOnly 'org.projectlombok:lombok'
annotationProcessor 'org.projectlombok:lombok'

implementation project(':common')
implementation project(':buckpal-application')
implementation project(':adapters:buckpal-persistence')
Expand Down
12 changes: 10 additions & 2 deletions build.gradle
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
plugins {
id "io.spring.dependency-management" version "1.0.8.RELEASE"
id "io.spring.dependency-management" version "1.0.9.RELEASE"
}

subprojects {
Expand All @@ -15,9 +15,17 @@ subprojects {
jcenter()
}

dependencies {
compileOnly 'org.projectlombok:lombok'
annotationProcessor 'org.projectlombok:lombok'

testCompileOnly 'org.projectlombok:lombok'
testAnnotationProcessor 'org.projectlombok:lombok'
}

dependencyManagement {
imports {
mavenBom("org.springframework.boot:spring-boot-dependencies:2.1.9.RELEASE")
mavenBom("org.springframework.boot:spring-boot-dependencies:2.2.6.RELEASE")
}
}

Expand Down