Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spawn Enemies #112

Merged
merged 5 commits into from
Nov 18, 2023
Merged

Spawn Enemies #112

merged 5 commits into from
Nov 18, 2023

Conversation

thombruce
Copy link
Owner

@thombruce thombruce commented Nov 18, 2023

closes #111
closes #83
closes #13

By submitting this pull request, you agree to follow our Code of Conduct: https://github.com/thombruce/.github/blob/main/CODE_OF_CONDUCT.md


Internal use. Do not delete.

  • Tests passing
  • Coverage sufficient
  • Manual review
  • No A11y regression
  • Translations provided or not needed

@thombruce
Copy link
Owner Author

thombruce commented Nov 18, 2023

TODO

  • Spawn indicators for newly spawned enemies
  • Spawn at semi-random location
  • Guarantee spawning outside of player view
  • Guarantee spawning greater than given distance from player
  • Cap/limit enemy spawning to under a given number

@thombruce
Copy link
Owner Author

Main thing above is to spawn indicators... This is going to be a bit tricky, as presently the indicator system spawns during setup.

We need to get the indicator container inside a different system, and spawn an indicator based on... the event of a new entity having been spawned. This could use the events system.

Key to how this works, we must not spawn new indicators every tick for entities that already have indicators. It is a one-and-done deal. So the indicator system must retain some knowledge or... if we use events, it matters a little less.

I think probably we should prefer to check each tick for entities without indicators and spawn for them.

So... iterate over entities, filtering for those that do not presently have a shown indicator, and spawn the indicator for them.

@thombruce thombruce marked this pull request as ready for review November 18, 2023 15:33
@thombruce
Copy link
Owner Author

Justification for adding #13 to the list of issues to be closed:

The "game" is officially "gamified".

There's a random element, it becomes harder and harder to outlast and survive, the player is rewarded with a score for every hit and every confirmed kill.

There's plenty more to add, like weapon and shield/invulnerability power-ups, different enemy types, more ways to increase your score, health drops, etc. etc. but some of this may be post-v0.1. The basic gameplay that the issue was setup to suggest be done... is now done.

@thombruce thombruce merged commit fc5fc25 into main Nov 18, 2023
6 checks passed
@thombruce thombruce deleted the feat/enemy-spawning branch November 18, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Player Health may go negative Randomness Gamifying the Game
1 participant