Typos and stuff I thought I'd clean up while following Part I #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gitbook disxussion link has been subject to bitrot, changed it to github issues.
(and these single ones ‘ ’ with ')
This makes it easier to find & replace characters like the problem quotes. Added a coupld of TODO notes where some of the text seems wrong, but I don't don't understand enough to fix it yet.
It didn't work before & this is more equivalant of the lists example it's contrasted with.
That's your external ip, but you want your machines ip on your network, not on the wider internet. (Unless you want to also get into port forwarding and router config here...) 127.0.0.1, the loopback address, will do for this example. In case anyone asks: On Windows, get it from `gip` or `Get-NetIPConfiguration` in Powershell On macOS/Linux you can find it in ifconfig as the most cross-platform way for all distros.
If the sine goes from -1 to 1, then -1+2=1 to 1+2=3 times 220 is 220 to 660, not 440 to 660.
Added some Windows shortcuts, and some emphasis, Fixed a typo, Removed one example that was repeated twice exactly the same, ... etc.
Couple of typos in the identifiers of synthdefs. linebreaks in "> quote boxes" were broken
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decided to learn SC properly instead of just editing examples without full understanding, and found this book on gitbooks.
Some examples were broken, mostly by "" and '' gettign formatted as “” and ‘ ’ and so on.