Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prescription build is failing adviser release #2402

Open
8 of 11 tasks
harshad16 opened this issue Dec 5, 2022 · 5 comments
Open
8 of 11 tasks

Prescription build is failing adviser release #2402

harshad16 opened this issue Dec 5, 2022 · 5 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/stack-guidance Categorizes an issue or PR as relevant to SIG Stack Guidance.

Comments

@harshad16
Copy link
Member

harshad16 commented Dec 5, 2022

Prescription build is failing adviser release.
Logs:

{"name": "thoth.adviser.prescription.v1.prescription", "levelname": "ERROR", "module": "prescription", "lineno": 302, "funcname": "load", "created": 1670231438.3877933, "asctime": "2022-12-05 09:10:38,387", "msecs": 387.79330253601074, "relative_created": 2576.369047164917, "process": 1565, "message": "Failed to load prescription from '\''prescriptions/fs/gh_link.yaml'\''"}
Traceback (most recent call last):
  File "/opt/app-root/lib64/python3.8/site-packages/thoth/adviser/prescription/v1/prescription.py", line 197, in from_dict
    PRESCRIPTION_SCHEMA(prescription)
  File "/opt/app-root/lib64/python3.8/site-packages/voluptuous/schema_builder.py", line 272, in __call__
    return self._compiled([], data)
  File "/opt/app-root/lib64/python3.8/site-packages/voluptuous/schema_builder.py", line 595, in validate_dict
    return base_validate(path, iteritems(data), out)
  File "/opt/app-root/lib64/python3.8/site-packages/voluptuous/schema_builder.py", line 433, in validate_mapping
    raise er.MultipleInvalid(errors)
voluptuous.error.MultipleInvalid: extra keys not allowed @ data['\''units'\'']['\''wraps'\''][0]['\''run'\'']['\''justification'\''][0]['\''metadata'\'']

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/opt/app-root/bin/thoth-adviser", line 8, in <module>
    sys.exit(cli())
  File "/opt/app-root/lib64/python3.8/site-packages/click/core.py", line 1130, in __call__
    return self.main(*args, **kwargs)
  File "/opt/app-root/lib64/python3.8/site-packages/click/core.py", line 1055, in main
    rv = self.invoke(ctx)
  File "/opt/app-root/lib64/python3.8/site-packages/click/core.py", line 1657, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/opt/app-root/lib64/python3.8/site-packages/click/core.py", line 1404, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/opt/app-root/lib64/python3.8/site-packages/click/core.py", line 760, in invoke
    return __callback(*args, **kwargs)
  File "/opt/app-root/lib64/python3.8/site-packages/thoth/adviser/cli.py", line 979, in validate_prescription
    prescription = Prescription.validate(prescriptions)
  File "/opt/app-root/lib64/python3.8/site-packages/thoth/adviser/prescription/v1/prescription.py", line 116, in validate
    prescription_instance = cls.load(prescriptions)
  File "/opt/app-root/lib64/python3.8/site-packages/thoth/adviser/prescription/v1/prescription.py", line 295, in load
    prescription_instance = cls.from_dict(
  File "/opt/app-root/lib64/python3.8/site-packages/thoth/adviser/prescription/v1/prescription.py", line 203, in from_dict
    raise PrescriptionSchemaError(str(exc))
thoth.adviser.exceptions.PrescriptionSchemaError: extra keys not allowed @ data['\''units'\'']['\''wraps'\''][0]['\''run'\'']['\''justification'\''][0]['\''metadata'\'']
subprocess exited with status 1
subprocess exited with status 1

Originally posted by @harshad16 in #2401 (comment)

Acceptance criteria

Related work:

@codificat
Copy link
Member

/sig stack-guidance
/kind bug
/priority critical-urgent

@sesheta sesheta added sig/stack-guidance Categorizes an issue or PR as relevant to SIG Stack Guidance. kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Jan 9, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in Planning Board Jan 9, 2023
@codificat codificat added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Jan 9, 2023
@codificat
Copy link
Member

/assign

@VannTen
Copy link
Member

VannTen commented Jan 18, 2023

Should we delete invalid prescriptions completely ? With the pre-commit hooks working it should be quite easy to get a list of offending files.

@VannTen
Copy link
Member

VannTen commented Jan 18, 2023

/assign
(I'm doing some stuff around this)

@codificat
Copy link
Member

/unassign

@VannTen VannTen removed their assignment Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/stack-guidance Categorizes an issue or PR as relevant to SIG Stack Guidance.
Projects
Status: 🏗 In progress
Development

No branches or pull requests

4 participants