validate prescriptions with pre-commit hook using adviser #38951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sesheta
added
do-not-merge/hold
VannTen
changed the title
|
/test all |
VannTen
force-pushed
the
feat/pre-commmit-validate-prescriptions
branch
from
a37387f to
e7c60fc
Compare
|
/unhold |
sesheta
removed
the
do-not-merge/hold
codificat
requested changes
Feb 3, 2023
.pre-commit-config.yaml
Outdated
Comment on lines
24
to
26
| - id: validate-prescriptions | ||
| files: prescriptions/ | ||
| exclude: prescriptions/_prescription_metadata.yaml |
There was a problem hiding this comment.
yamllint is complaining: error wrong indentation: expected 2 but found 4 (indentation)
VannTen
force-pushed
the
feat/pre-commmit-validate-prescriptions
branch
from
e7c60fc to
4d5c139
Compare
Once we have a proper release of adviser we'll use that
|
of course I had to forget the other pre-commit hooks :/ |
|
/lgtm thanks! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: codificat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sesheta
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues and Dependencies
fix #8
thoth-station/adviser#2402
This introduces a breaking change
This should yield a new module release
This Pull Request implements
Add a pre-commit hooks to validate prescriptions.
In conjonction with --from-ref / --to-ref, this should only validates files touched in a PR
This on my fork of thoth-station/adviser because it needs thoth-station/adviser#2411 and #2408 to be merged first.
By the way, we really need operate-first/apps#2462 on this repo. It would allow us to implement pre-commit hook caching instead of installing every single time, which would save a lot of prow-time. (well, once it comes back up...)
/hold