Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Horus: jupyterlab requirements CLI #341

Merged
merged 16 commits into from
Jul 16, 2021

Conversation

pacospace
Copy link
Contributor

@pacospace pacospace commented Jul 12, 2021

Signed-off-by: Francesco Murdaca [email protected]

Related Issues and Dependencies

Fixes: #324
Fixes: #245
Fixes: #203

This introduces a breaking change

  • Yes
  • No

This Pull Request implements

Introduce CLI commands to manage dependencies in the notebook

@sesheta sesheta added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 12, 2021
@pacospace pacospace changed the title Introduce jupyterlab requirements CLI WIP: Introduce jupyterlab requirements CLI Jul 12, 2021
@sesheta sesheta added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 12, 2021
@pacospace pacospace force-pushed the jupyterlab-requirements-cli branch from 84f4ec1 to 65fe834 Compare July 12, 2021 13:22
@pacospace
Copy link
Contributor Author

/retest

@pacospace pacospace force-pushed the jupyterlab-requirements-cli branch 3 times, most recently from 8260cad to 5ef1f93 Compare July 13, 2021 08:12
@sesheta sesheta added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 13, 2021
@pacospace pacospace force-pushed the jupyterlab-requirements-cli branch from 9b38b21 to d485f3b Compare July 13, 2021 16:14
@sesheta sesheta added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 14, 2021
@pacospace pacospace force-pushed the jupyterlab-requirements-cli branch 2 times, most recently from b59a695 to 0c2b90b Compare July 14, 2021 14:06
Francesco Murdaca added 11 commits July 16, 2021 11:49
Signed-off-by: Francesco Murdaca <[email protected]>
Signed-off-by: Francesco Murdaca <[email protected]>
Signed-off-by: Francesco Murdaca <[email protected]>
Signed-off-by: Francesco Murdaca <[email protected]>
Signed-off-by: Francesco Murdaca <[email protected]>
Signed-off-by: Francesco Murdaca <[email protected]>
Signed-off-by: Francesco Murdaca <[email protected]>
@pacospace pacospace force-pushed the jupyterlab-requirements-cli branch from e2c52fc to 9c639fe Compare July 16, 2021 09:52
Signed-off-by: Francesco Murdaca <[email protected]>
@todo
Copy link

todo bot commented Jul 16, 2021

Provide Pipfile.lock retrieved?

pipfile_lock="", # TODO: Provide Pipfile.lock retrieved?
force=force,
config=config,
origin=origin,
nowait=False,
source_type=ThothAdviserIntegrationEnum.JUPYTER_NOTEBOOK,


This comment was generated by todo based on a TODO comment in 137969b in #341. cc @pacospace.

Signed-off-by: Francesco Murdaca <[email protected]>
@pacospace pacospace force-pushed the jupyterlab-requirements-cli branch 3 times, most recently from fd9d414 to d9058d9 Compare July 16, 2021 19:11
@pacospace pacospace changed the title WIP: Introduce jupyterlab requirements CLI Introduce jupyterlab requirements CLI Jul 16, 2021
@sesheta sesheta removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 16, 2021
@pacospace pacospace force-pushed the jupyterlab-requirements-cli branch from d9058d9 to dd3c83c Compare July 16, 2021 19:34
@pacospace pacospace force-pushed the jupyterlab-requirements-cli branch from dd3c83c to 0d63360 Compare July 16, 2021 19:53
@pacospace pacospace changed the title Introduce jupyterlab requirements CLI Introduce Horus jupyterlab requirements CLI Jul 16, 2021
@pacospace pacospace changed the title Introduce Horus jupyterlab requirements CLI Introduce Horus: jupyterlab requirements CLI Jul 16, 2021
Signed-off-by: Francesco Murdaca <[email protected]>
@pacospace pacospace force-pushed the jupyterlab-requirements-cli branch from 6bbc45f to 8a586fc Compare July 16, 2021 20:35
@pacospace
Copy link
Contributor Author

/approve

@sesheta
Copy link
Member

sesheta commented Jul 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pacospace

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@sesheta
Copy link
Member

sesheta commented Jul 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pacospace

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2021
Signed-off-by: Francesco Murdaca <[email protected]>
@pacospace pacospace force-pushed the jupyterlab-requirements-cli branch from 8a586fc to 0b76248 Compare July 16, 2021 20:40
@sesheta sesheta merged commit 10d8fbb into thoth-station:master Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
2 participants