Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow passing indexes where package dependencies should be looked up #2336

Merged
merged 1 commit into from
Feb 14, 2022
Merged

Allow passing indexes where package dependencies should be looked up #2336

merged 1 commit into from
Feb 14, 2022

Conversation

fridex
Copy link
Contributor

@fridex fridex commented Feb 9, 2022

Related Issues and Dependencies

Related: thoth-station/solver#5111
Related: thoth-station/graph-refresh-job#669
Related: #2272

This introduces a breaking change

  • No

Description

Allow passing new environment variable for solvers, which would check indexes for possible dependencies (cross-index resolution).

@sesheta sesheta added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 9, 2022
@sesheta sesheta requested review from goern and pacospace February 9, 2022 17:43
@fridex fridex force-pushed the thoth-dependency-indexes branch from bcda24a to 0f4bba0 Compare February 9, 2022 17:44
@sesheta sesheta added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 9, 2022
@fridex fridex marked this pull request as draft February 9, 2022 17:47
@sesheta sesheta added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 9, 2022
@fridex fridex marked this pull request as ready for review February 14, 2022 10:38
@sesheta sesheta removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 14, 2022
@fridex
Copy link
Contributor Author

fridex commented Feb 14, 2022

Required by #2344 and #2343 This merge would eventually break solver workflows in prod deployment, but as prod does not run solvers, I think we could have this in. I will work on testing to make sure today's release has this properly fixed.

/unhold
/approve

@sesheta
Copy link
Member

sesheta commented Feb 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fridex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2022
@fridex fridex merged commit c631194 into thoth-station:master Feb 14, 2022
@fridex fridex deleted the thoth-dependency-indexes branch February 14, 2022 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goern goern Awaiting requested review from goern

@pacospace pacospace Awaiting requested review from pacospace

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fridex @sesheta