-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load project from URL GET parameter-pradeep #98
base: main
Are you sure you want to change the base?
Conversation
|
Hi @pradeepkumara this looks great, and I believe it should implement the functionality as expected. However, there are two points that I think could be considered further:
|
Overall, it looks good. By the way, one additional point to consider is that some comments seem to have been removed in this update. These comments provide valuable context and might be worth keeping in the code to ensure clarity and maintainability. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the helpful feedback! I'll add comments in the code to explain what I've changed and what everything does.
Description
i just changed those files where i need to change all the functions, inside IDEStartup and SplashkitOnline js
Fixes # (issue)
Type of change
Please delete options that are not relevant.
expected)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can
reproduce. Please also list any relevant details for your test configuration
Testing Checklist
Checklist