Spiders #197
Closed
Spiders #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… did this a few times)
… player 1 controls on the arcade machine
…ould be compatible with arcade machine
…n 5 characters are entered, rather than needing to select continue
…t not sure how to easily do that without looping sound currently
…t will handle the incorrect password
…, goes away when selection changed
… to move selection to for smoother use
…. This is to avoid issues with the password auto submit
…cumentation folder
…y collision to be detected (sound only) and made them non=solid
…y (to avoid being hit continuously), not fully functional yet
…'. Allows for a new player object to be created/reset after taking damage without affecting number of gems displayed, since the gems remaining is not tied to player object anyway
… game over set-up yet
…u upon game over (0 lives)
…en modified by others
…me.cpp (game.cpp is more akin to a 'level' rather than entire game, as a new 'game' object is created for each level'
…to starting tile. Stylistic changes - made stairs into a campfire that gets lit, with a sound effect. Changed gems to red gems ('fire rubies'?)
…th thanks to Oscar
… movement of enemies, work in progress
…h correctly with solid tiles
…to fix spider speed + also bug when pushing box into spider allows player to walk through the box
… of next positions for enemies
…stly issue with box not moving fully if hit
… down however animation possibly shouldn't be used for movement as makes calculation of tile_ID fickle (rounding will occur)
…h not idea, movement should possibly be reworked in future. Finished enemy box collision function. There is a bug where box can still be pushed into enemy if coming from a different direction, this is due to the way it checks direction. Should really use the keys however there were issues with walking through boxes when I did that. Still working on it
… fixed. Changed where box_enemy_collision was being called
… box_enemy_collision function and separated parts of it into the different key_down checks. Seems to be fixed
…ing trapped in box on collision
…for testing/debugging - only have to change one number now
|
Will resolve conflicts on main and make a new PR (again!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The main purpose of this pull request was to add enemy functionality to the game, however there have also been some bug fixes and design tweaks during this process. Please refer to commit bff6059 (May 12th) onwards as this is where the branch deviates from main/pull request 187. I plan to created a another PR shortly to create documentation to assist with future work on this game.
A summary of most significant changes is as follows
Added enemy functionality
destroy enemies)
Design/aesthetic changes
Other fixes
of the level count and win conditions, while game.cpp controls (primarily) individual levels. Refactor would be useful in
future
Type of change
How Has This Been Tested?
Tested individually by myself. Have played the game in full and attempted numerous scenarios to test for issues. I may create a recommendation report as part of my documentation PR as there's a few things I that could be improved on, but nothing I can find that is game-breaking. Tested on Windows.
Checklist
- This will be forthcoming in a new PR. There is very little existing documentation so this will be a larger job.
- Game generates a "libpng warning: iCCP: known incorrect sRGB profile". Not sure if this is device specific or if it existed
before but does not appear to impact game.