Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Below the Surface - fix bugs on password screen #210

Merged

Conversation

MHLoppy
Copy link
Contributor

@MHLoppy MHLoppy commented May 16, 2024

Description

#187 unfortunately introduced the following two minor bugs on the password input screen:

  • The console output is flooded with empty lines until a password is entered.
  • Moving up from "G" moves to "EXIT" instead of "A".

I've resolved both, though it's possible having the password written to console was leftover debugging and should be removed rather than fixed (waiting to hear back about it) with the console output being removed as Castiel says it was just leftover debugging.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

I did before/after tests with the fixes applied vs not applied for the following:

  • Waiting on the password input screen and monitoring the console output.
  • Continuing past the password input screen and monitoring the console output.
  • Moving up, down, left, and right for each and every possible input character, as well as for DEL, and EXIT.

Testing Checklist

N/A

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation (N/A)
  • My changes generate no new warnings
  • I'll mark my work as ready for peer review

@github-actions github-actions bot added the compiled the source code has been successfully compiled label May 16, 2024
@MHLoppy MHLoppy changed the title Fix/belowthesurface fix password screen Below the Surface - fix bugs on password screen May 16, 2024
@MHLoppy MHLoppy marked this pull request as ready for review May 17, 2024 08:29
@MHLoppy
Copy link
Contributor Author

MHLoppy commented May 17, 2024

Copy link
Contributor

@CastielM CastielM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, have compiled and also tested each key, apologies for missing those! As Oscar mentioned with these changes initially, someone may want to tackle changing the way the way the keyboard is generated next trimester(such as a 2D array), as it's a little dodgy using the 1D, especially if anyone adjusts it in future (and the up/down at the W, X, Y, Z are not ideal, but manageable).

@AmberPotion AmberPotion merged commit f627ed7 into thoth-tech:main Sep 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiled the source code has been successfully compiled
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants