-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI fixes #19
CI fixes #19
Conversation
Have these changes been tested on Mac and Windows? |
Unit tests work on Mac. I tested the CI GitHub actions workflow on my fork too for these commits and they all succeed now. The implemented cache functionality also makes it run faster the second time around. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks very good. If we can get that one new environment variable explained alongside the other environment variables in the README I think... then it should be good to merge.
Once this is addressed you can make the PR to the main repo. |
This one looks good now please make upstream. |
Pull request opened upstream: doubtfire-lms#434 |
Please merge #18 first. This took me weeks to figure out and test, now everything is finally working as they should.
Improvements made:
ruby-lsp
in the development environment for the corresponding vscode extension, which is currently already installed in the devcontainer but completely useless due to the gem being missing.database_populator.rb
to report the error messages when there's something wrong with the test data. Troubleshooting test db initialization issues should be much easier now.Instruction for reviewers: just check the CI workflows below and they should be all passing now.