forked from doubtfire-lms/doubtfire-deploy
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: External TeX Live docker container #13
Open
b0ink
wants to merge
14
commits into
thoth-tech:development
Choose a base branch
from
b0ink:refactor/latex-docker-downsize-deploy
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Refactor: External TeX Live docker container #13
b0ink
wants to merge
14
commits into
thoth-tech:development
from
b0ink:refactor/latex-docker-downsize-deploy
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- allows shared volumes to work when running containers through vscode dev container
…-docker-downsize-deploy
13 tasks
b0ink
changed the title
Refactor: separate docker container for Texlive and Latex processing
Refactor: External TeX Live docker container
Aug 20, 2024
This looks good and works as intended. |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on thoth-tech/doubtfire-api#38
Feasibility document: thoth-tech/documentation#534
Description
This update takes the TeX Live installation out of the current
dev.Dockerfile
and creates a new container using the official TeX Live Docker image. This will improve the process of building and deploying the main image as it no longer requires downloading and installing TeX Live.Similar to the main container, the texlive container is kept alive using
in the docker-compose setup, allowing doubtfire-api to
docker exec
into this container without needing to spin a new container up.The latex_build.sh script is copied from doubtfire-api into the TeX Live container, and executed in the
docker exec
command, which will then run lualatex.Two additional environment variables are defined in
devcontainer.env
These env variables are used in latex_run.sh, and validated in the latex_helper.rb module, which requires the name of the TeX Live container to
docker exec
into, and the path to where thelatex_build.sh
is stored on the TeX Live container, as this is defined in texlive.Dockerfile