Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: changed Numbas delay input and fixed attempt limit not showing on refresh #151

Merged

Conversation

satikaj
Copy link
Collaborator

@satikaj satikaj commented Mar 23, 2024

Description

Fixed the bug wherein the previously configured attempt limit won't show on refresh. Also changed the time delay input to a checkbox to enable incremental delays instead of specifying the delay.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Before

Screenshot 2024-03-23 at 5 38 17 PM

After

image

Testing Checklist:

  • Tested in latest Chrome
  • Tested in latest Safari
  • Tested in latest Firefox

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@satikaj satikaj changed the title fix: show previously configured Numbas attempt limit fix: changed Numbas delay input and fixed attempt limit not showing on refresh Mar 24, 2024
@maddernd maddernd merged commit dcb4403 into thoth-tech:add-numbas-integration Mar 25, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants