refactor: component cleanup #152
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ublefo
force-pushed
the
refactor/module-cleanup
branch
from
21f0cf5 to
c9fa0f2
Compare
|
Tested locally and all good to merge. |
maddernd
approved these changes
Mar 28, 2024
|
Lets get this one made upstream. |
|
Pull request opened upstream: doubtfire-lms#823 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have identified some unused components in the source tree that was not referenced anywhere else, let's clean them up now. I've checked whether the modules are in use or not with the following steps. When both of them return no matches, I will deem a component unused.
tutorGroupManager.tutor-group-managerto check if the component is being used by anything else other than the import lists.Tested in Chrome and everything seems to work, unit tests are all broken so I'm unable to run them.
The following components are currently unused but not removed, those should be migrated so we can put them back into the UI.