fix: remove the incorrect option from for scrollIntoView() #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"top" is not a valid option, "start" is the default so there is no need to define it explicitly
|
Code is good. Firefox is the only browser that really complains about this from the 3 and the error disappears after this fix is applied. All good to be merged @maddernd |
|
please add screenshots showing before and after of what you changed |
|
After adding screenshots please make this upstream. |
|
Closed in favor of doubtfire-lms#824 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are a lot of errors in the javascript console when clicking on the tasks in the task list:
topis not a valid option forscrollIntoView(),startis the default so there is no need to define it explicitly.https://developer.mozilla.org/en-US/docs/Web/API/Element/scrollIntoView
Type of change
How Has This Been Tested?
The aforementioned errors are no longer present in the javascript console when switching tasks.
Testing Checklist:
Checklist: