Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration: comments-modal component #155

Open
wants to merge 4 commits into
base: development
Choose a base branch
from

Conversation

s223749059
Copy link

@s223749059 s223749059 commented Apr 4, 2024

Description

Migrate the comments-modal component from CoffeeScript and Angular.js to TypeScript and Angular. The component is located in the comment section and applied for image and pdf comment types. In that, users can click on the comment to display the original size of the files. And, allowing download functions.

How Has This Been Tested?

  • First, log in to the OnTrack application.
  • Navigate to the comment section (In the right hand side of the web page, the comment section displays conversations between students and tutors in each specific unit task).
  • Sending image and pdf comments.
  • After that, when clicking on the comment files, it displays the original size and allows users to download the comments.
  • Note: In the migration process, there are modifications on functions. In that, the functions display the image comments, and directly download pdf comment files. There are inform alerts after the file is downloaded.

Before:

comments_modal_image comments_modal_pdf

After:

comments_modal_image_migrated comments_modal_pdf_migrated_alerts comments_modal_pdf_migrated_handling

Testing Checklist:

  • Tested in latest Chrome
  • Tested in latest Safari
  • Tested in latest Firefox

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@s223749059
Copy link
Author

The component review for Migration: comments-modal is completed with a pull request into thoth-tech/documentation repository: thoth-tech/documentation#478.

@maddernd
Copy link

maddernd commented Apr 6, 2024

The after picture looks very different to the before picture, this will need fixing up so it looks exactly the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants