Upgraded Rollup and its dependencies to the latest versions #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This required changing the config's file extension to `.mjs`. I read through the upgrade notes and did not see any other major changes that would fail silently.
pangolingo
force-pushed
the
di-rollup-upgrades
branch
from
f6b6574 to
4167a25
Compare
|
I compared the built files (files in the |
rakeshpetit
reviewed
Jan 17, 2025
| "ts-jest": "^29.2.5", | ||
| "tsd": "^0.31.2", | ||
| "tslib": "^2.8.1", | ||
| "typescript": "^5.7.3" | ||
| }, | ||
| "dependencies": { | ||
| "lodash.mergewith": "^4.6.2" | ||
| } | ||
| }, | ||
| "packageManager": "[email protected]+sha512.a6b2f7906b721bba3d67d4aff083df04dad64c399707841b7acf00f6b133b7ac24255f2652fa22ae3534329dc6180534e98d17432037ff6fd140556e2bb3137e" |
There was a problem hiding this comment.
Do we have to mention this? What would happen if we did not add the packageManager?
rakeshpetit
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This required changing the config's file extension to
.mjs. I read through the upgrade notes and did not see any other major changes that would fail silently.This builds on another PR: #149