Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix undefined method run_n_unit_test_suite #93

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Appraisals
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ appraise "rails_6_0" do
gem "jbuilder", "~> 2.7"
gem "bcrypt", "~> 3.1.7"
gem "bootsnap", ">= 1.4.2", require: false
gem "listen", ">= 3.0.5", "< 3.2"
gem 'listen', '~> 3.2'
gem "spring-watcher-listen", "~> 2.0.0"
gem "capybara", ">= 2.15"
gem "selenium-webdriver"
Expand All @@ -55,8 +55,9 @@ appraise "rails_6_1" do
gem "jbuilder", "~> 2.7"
gem "bcrypt", "~> 3.1.7"
gem "bootsnap", ">= 1.4.2", require: false
gem "listen", ">= 3.0.5", "< 3.2"
gem 'listen', '~> 3.2'
gem "spring-watcher-listen", "~> 2.0.0"
gem "rack-mini-profiler", "~> 2.0.0"
gem "capybara", ">= 2.15"
gem "selenium-webdriver"
gem "sqlite3", "~> 1.4.0"
Expand Down
2 changes: 1 addition & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,6 @@ gem "pry", "~> 0.12.0"
gem "pry-byebug", "~> 3.6.0"
gem "rake"
gem "rubocop", "0.71.0"
gem "snowglobe", ">= 0.3.0"
gem "snowglobe", git: "https://github.com/mcmire/snowglobe.git", branch: "master"
gem "test-unit"
gem "warnings_logger"
10 changes: 8 additions & 2 deletions Gemfile.lock
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
GIT
remote: https://github.com/mcmire/snowglobe.git
revision: 812e1cdb07038c2327f15c76082cef9329f70430
branch: master
specs:
snowglobe (0.3.0)

PATH
remote: .
specs:
Expand Down Expand Up @@ -40,7 +47,6 @@ GEM
ruby-progressbar (~> 1.7)
unicode-display_width (>= 1.4.0, < 1.7)
ruby-progressbar (1.10.1)
snowglobe (0.3.0)
test-unit (3.3.5)
power_assert
thor (1.0.1)
Expand All @@ -62,7 +68,7 @@ DEPENDENCIES
rake
rubocop (= 0.71.0)
shoulda-context!
snowglobe (>= 0.3.0)
snowglobe!
test-unit
warnings_logger

Expand Down
4 changes: 2 additions & 2 deletions gemfiles/rails_6_0.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ gem "pry", "~> 0.12.0"
gem "pry-byebug", "~> 3.6.0"
gem "rake"
gem "rubocop", "0.71.0"
gem "snowglobe", ">= 0.3.0"
gem "snowglobe", git: "https://github.com/mcmire/snowglobe.git", branch: "master"
gem "test-unit"
gem "warnings_logger"
gem "sqlite3", "~> 1.4.0"
Expand All @@ -27,7 +27,7 @@ gem "turbolinks", "~> 5"
gem "jbuilder", "~> 2.7"
gem "bcrypt", "~> 3.1.7"
gem "bootsnap", ">= 1.4.2", require: false
gem "listen", ">= 3.0.5", "< 3.2"
gem "listen", "~> 3.2"
gem "spring-watcher-listen", "~> 2.0.0"
gem "capybara", ">= 2.15"
gem "selenium-webdriver"
Expand Down
22 changes: 13 additions & 9 deletions gemfiles/rails_6_0.gemfile.lock
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
GIT
remote: https://github.com/mcmire/snowglobe.git
revision: e0b1c04da37bae7e820c6cf2b962bc0edfdddd7d
branch: master
specs:
snowglobe (0.3.0)

PATH
remote: ..
specs:
Expand Down Expand Up @@ -88,7 +95,7 @@ GEM
crass (1.0.6)
digest (3.1.1)
erubi (1.12.0)
ffi (1.15.5)
ffi (1.16.3)
globalid (1.1.0)
activesupport (>= 5.0)
i18n (1.12.0)
Expand All @@ -98,10 +105,9 @@ GEM
jbuilder (2.11.5)
actionview (>= 5.0.0)
activesupport (>= 5.0.0)
listen (3.1.5)
rb-fsevent (~> 0.9, >= 0.9.4)
rb-inotify (~> 0.9, >= 0.9.7)
ruby_dep (~> 1.2)
listen (3.9.0)
rb-fsevent (~> 0.10, >= 0.10.3)
rb-inotify (~> 0.9, >= 0.9.10)
loofah (2.19.1)
crass (~> 1.0.2)
nokogiri (>= 1.5.9)
Expand Down Expand Up @@ -208,7 +214,6 @@ GEM
unicode-display_width (>= 1.4.0, < 1.7)
ruby-progressbar (1.12.0)
ruby2_keywords (0.0.5)
ruby_dep (1.5.0)
rubyzip (2.3.2)
sass-rails (6.0.0)
sassc-rails (~> 2.1, >= 2.1.1)
Expand All @@ -223,7 +228,6 @@ GEM
selenium-webdriver (3.142.7)
childprocess (>= 0.5, < 4.0)
rubyzip (>= 1.2.2)
snowglobe (0.3.0)
spring (2.1.1)
spring-commands-rspec (1.0.4)
spring (>= 0.9.1)
Expand Down Expand Up @@ -278,7 +282,7 @@ DEPENDENCIES
byebug
capybara (>= 2.15)
jbuilder (~> 2.7)
listen (>= 3.0.5, < 3.2)
listen (~> 3.2)
m
minitest
minitest-reporters
Expand All @@ -294,7 +298,7 @@ DEPENDENCIES
sass-rails (>= 6)
selenium-webdriver
shoulda-context!
snowglobe (>= 0.3.0)
snowglobe!
spring
spring-commands-rspec
spring-watcher-listen (~> 2.0.0)
Expand Down
5 changes: 3 additions & 2 deletions gemfiles/rails_6_1.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ gem "bundler", "~> 1.0"
gem "byebug"
gem "capybara", ">= 2.15"
gem "jbuilder", "~> 2.7"
gem "listen", ">= 3.0.5", "< 3.2"
gem "listen", "~> 3.2"
gem "m"
gem "minitest"
gem "minitest-reporters"
Expand All @@ -18,13 +18,14 @@ gem "pg", ">= 0.18", "< 2.0"
gem "pry", "~> 0.12.0"
gem "pry-byebug", "~> 3.6.0"
gem "puma", "~> 5.0"
gem "rack-mini-profiler", "~> 2.0.0"
gem "rails", "~> 6.1.3.2"
gem "rails-controller-testing", ">= 1.0.4"
gem "rake"
gem "rubocop", "0.71.0"
gem "sass-rails", ">= 6"
gem "selenium-webdriver"
gem "snowglobe", ">= 0.3.0"
gem "snowglobe", git: "https://github.com/mcmire/snowglobe.git", branch: "master"
gem "spring"
gem "spring-commands-rspec"
gem "spring-watcher-listen", "~> 2.0.0"
Expand Down
25 changes: 16 additions & 9 deletions gemfiles/rails_6_1.gemfile.lock
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
GIT
remote: https://github.com/mcmire/snowglobe.git
revision: e0b1c04da37bae7e820c6cf2b962bc0edfdddd7d
branch: master
specs:
snowglobe (0.3.0)

PATH
remote: ..
specs:
Expand Down Expand Up @@ -92,7 +99,7 @@ GEM
crass (1.0.6)
date (3.3.3)
erubi (1.12.0)
ffi (1.15.5)
ffi (1.16.3)
globalid (1.1.0)
activesupport (>= 5.0)
i18n (1.14.1)
Expand All @@ -101,10 +108,9 @@ GEM
jbuilder (2.11.5)
actionview (>= 5.0.0)
activesupport (>= 5.0.0)
listen (3.1.5)
rb-fsevent (~> 0.9, >= 0.9.4)
rb-inotify (~> 0.9, >= 0.9.7)
ruby_dep (~> 1.2)
listen (3.9.0)
rb-fsevent (~> 0.10, >= 0.10.3)
rb-inotify (~> 0.9, >= 0.9.10)
loofah (2.21.3)
crass (~> 1.0.2)
nokogiri (>= 1.12.0)
Expand Down Expand Up @@ -160,6 +166,8 @@ GEM
nio4r (~> 2.0)
racc (1.7.1)
rack (2.2.7)
rack-mini-profiler (2.0.4)
rack (>= 1.2.0)
rack-test (2.1.0)
rack (>= 1.3)
rails (6.1.3.2)
Expand Down Expand Up @@ -210,7 +218,6 @@ GEM
unicode-display_width (>= 1.4.0, < 1.7)
ruby-progressbar (1.13.0)
ruby2_keywords (0.0.5)
ruby_dep (1.5.0)
rubyzip (2.3.2)
sass-rails (6.0.0)
sassc-rails (~> 2.1, >= 2.1.1)
Expand All @@ -226,7 +233,6 @@ GEM
rexml (~> 3.2, >= 3.2.5)
rubyzip (>= 1.2.2, < 3.0)
websocket (~> 1.0)
snowglobe (0.3.0)
spring (2.1.1)
spring-commands-rspec (1.0.4)
spring (>= 0.9.1)
Expand Down Expand Up @@ -276,7 +282,7 @@ DEPENDENCIES
byebug
capybara (>= 2.15)
jbuilder (~> 2.7)
listen (>= 3.0.5, < 3.2)
listen (~> 3.2)
m
minitest
minitest-reporters
Expand All @@ -285,14 +291,15 @@ DEPENDENCIES
pry (~> 0.12.0)
pry-byebug (~> 3.6.0)
puma (~> 5.0)
rack-mini-profiler (~> 2.0.0)
rails (~> 6.1.3.2)
rails-controller-testing (>= 1.0.4)
rake
rubocop (= 0.71.0)
sass-rails (>= 6)
selenium-webdriver
shoulda-context!
snowglobe (>= 0.3.0)
snowglobe!
spring
spring-commands-rspec
spring-watcher-listen (~> 2.0.0)
Expand Down
4 changes: 2 additions & 2 deletions test/shoulda/rerun_snippet_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
class RerunSnippetTest < PARENT_TEST_CASE
context "A Rails application with shoulda-context added to it" do
should "display the correct rerun snippet when a test fails" do
if app.rails_version >= 5 && TEST_FRAMEWORK == "minitest"
if TEST_FRAMEWORK == "minitest"
app.create

app.write_file("test/models/failing_test.rb", <<~RUBY)
Expand Down Expand Up @@ -44,7 +44,7 @@ def failure_message_when_negated

command_runner = app.run_n_unit_test_suite

expected_executable = rails_version >= 6 ? "rails test" : "bin/rails test"
expected_executable = "rails test"

assert_includes(command_runner.output, "#{expected_executable} test/models/failing_test.rb:27")
assert_includes(command_runner.output, "#{expected_executable} test/models/failing_test.rb:31")
Expand Down
Loading