-
-
Notifications
You must be signed in to change notification settings - Fork 910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Ruby 2.7.2 for development and CI #1369
Conversation
@vsppedro I think that depends on whether we are ready to talk about 5.0. If we're going to be talking about that then perhaps we should although think about other things we could possibly deprecate? For instance, I really wonder how often controller matchers get used (they're more useful in a Minitest context, but even controller tests are deprecated now in Rails). Do we really need database column matchers? etc. But maybe it's worth starting that discussion. |
Aside from that, this looks good, so I'll merge :) |
@vsppedro Eh... maybe. 😆 I made that milestone a while back just so the next release would be somewhat focused instead of cramming as much stuff as possible into one release as I have done in years past. Also, with every new release, I have tried to make sure I am addressing old issues as well as new ones, but at this point that strategy has failed too 🙄 So... I say if we want to release a new major version, we should focus on that and everything that entails and not worry so much about what it is in the backlog (unless there's something we've always wanted to fix that requires a backward incompatible change — although I'm having a hard time thinking of an example right now). |
I'll try to help to finish that milestone. 😄 |
Good catch @vsppedro . I have created
I think our major release ( |
@vsppedro I gave @KapilSachdev commit access and it sounds like you may want to do more work so I have given you commit access as well. I will let y'all coordinate on what you want to include in 4.5.0 :) |
Thank you very much! |
I made the update following the changes made on this PR #1310.
What do you think about dropping the support for old Ruby versions and Rails 4.2 like suggested in this comment: #1324 (comment)
One of the advantages would be the reduction of time of the CI.