Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Ruby 2.7.2 for development and CI #1369

Merged
merged 1 commit into from
Nov 3, 2020

Conversation

vsppedro
Copy link
Collaborator

@vsppedro vsppedro commented Nov 2, 2020

I made the update following the changes made on this PR #1310.

What do you think about dropping the support for old Ruby versions and Rails 4.2 like suggested in this comment: #1324 (comment)

One of the advantages would be the reduction of time of the CI.

@mcmire
Copy link
Collaborator

mcmire commented Nov 3, 2020

@vsppedro I think that depends on whether we are ready to talk about 5.0. If we're going to be talking about that then perhaps we should although think about other things we could possibly deprecate? For instance, I really wonder how often controller matchers get used (they're more useful in a Minitest context, but even controller tests are deprecated now in Rails). Do we really need database column matchers? etc. But maybe it's worth starting that discussion.

@mcmire
Copy link
Collaborator

mcmire commented Nov 3, 2020

Aside from that, this looks good, so I'll merge :)

@mcmire mcmire merged commit 02396a8 into thoughtbot:master Nov 3, 2020
@vsppedro vsppedro deleted the update-ruby branch November 3, 2020 19:52
@vsppedro
Copy link
Collaborator Author

vsppedro commented Nov 3, 2020

@mcmire I think it's worth starting that discussion too. Should we finish the open milestone first?

@mcmire
Copy link
Collaborator

mcmire commented Nov 8, 2020

@vsppedro Eh... maybe. 😆 I made that milestone a while back just so the next release would be somewhat focused instead of cramming as much stuff as possible into one release as I have done in years past. Also, with every new release, I have tried to make sure I am addressing old issues as well as new ones, but at this point that strategy has failed too 🙄

So... I say if we want to release a new major version, we should focus on that and everything that entails and not worry so much about what it is in the backlog (unless there's something we've always wanted to fix that requires a backward incompatible change — although I'm having a hard time thinking of an example right now).

@vsppedro
Copy link
Collaborator Author

vsppedro commented Nov 8, 2020

I'll try to help to finish that milestone. 😄

@KapilSachdev KapilSachdev added this to the 4.5.0 milestone Nov 11, 2020
@KapilSachdev
Copy link
Collaborator

Good catch @vsppedro . I have created 4.5.0 milestone, and is adding PRs that are merged after 4.4.1 under it. I hope i don't miss any.

So... I say if we want to release a new major version

I think our major release (5.0.0) will be the one where we would be removing the support for rails 4.2 for which we would be creating a deprecation workflow.
So I have taken the liberty to create a 4.5.0 milestone which would be our next version.

@mcmire
Copy link
Collaborator

mcmire commented Nov 11, 2020

@vsppedro I gave @KapilSachdev commit access and it sounds like you may want to do more work so I have given you commit access as well. I will let y'all coordinate on what you want to include in 4.5.0 :)

@vsppedro
Copy link
Collaborator Author

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants