feat: Add support for Rails 7.1 #1573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation This commit adjusts the way we manage columns and tables in migrations to account for the changes in Rails 7.1.0, it was introduced in this Rails version a validation around the options passed to tables and columns in migrations, so we need to adjust our code to skip this validation. This PR introduced this new validation on the migrations: rails/rails#46178
matsales28
force-pushed
the
feat/support-rails7.1
branch
from
86a4d80 to
6365ea5
Compare
This commit refines the `ActiveRecord::SerializeMatcher` to accommodate changes in the public API introduced in Rails 7.1. The `serialize` method's API has been updated, necessitating adjustments to our matcher specs to align with the new API. While this PR addresses the immediate need for compatibility, there is potential for further enhancements and refinements in the matcher's implementation to bring it in line with the revised public API. However, such improvements will be explored in a future PR. For reference, the changes in the public API can be found in the following PR: rails/rails#47463 This commit adjusts the `ActiveRecord::SerializeMatcher` the public API for the `serialize` method has changed on Rails 7.1, so we had to
matsales28
force-pushed
the
feat/support-rails7.1
branch
from
6365ea5 to
e836d24
Compare
The behavior of the comparison between hash and a `ActionController::Parameters` was changed and now will be deprecated. Check this Rails PR for more context rails/rails#44826.
The behaviour of this method was changed in Rails 7.1, and now it'll search for a `token` attr in the initialization of the record instead of the creation. To stay with the same behaviour as before it's necessary to pass a new argument `on: : create` to the method.
matsales28
force-pushed
the
feat/support-rails7.1
branch
from
0a27956 to
75612f6
Compare
This commit fixes the problem of not finding the tables when running the specs in eager load mode, this was introduced by Rails 7.1. Load the model schema when running test in eager load context rails/rails#49470
matsales28
force-pushed
the
feat/support-rails7.1
branch
from
b12fde3 to
aae4ed2
Compare
vsppedro
approved these changes
Nov 12, 2023
@vsppedro I like the idea, but do you mean support for Ruby 3.3, right? If I'm not wrong we are already supporting Ruby 3.2. I have never released a new version of a gem. If we can do that together somehow I'd love to participate. |
|
@matsales28, yes, for 3.3. It's a great idea for you to lead this release. I'll support you. Lately, I've lacked energy for open source, but I'm changing that. This weekend, I'll start a PR for Ruby 3.3 support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for Rails 7.1 version, there are several commits each one fixing one problem in the specs. I'd recommend going through them one by one when reviewing, it'll be easier to review.