Added v7 and OpenTelemetry Stream support #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jabrowne-te
requested review from
sfreitas-te,
joaomper-TE,
brumarqu-te,
phpinhei-te,
vascmart-te,
mpragosa-te and
shahid-te
jabrowne-te
reviewed
Oct 24, 2024
Comment on lines
+15
to
+24
| type Stream struct { | ||
| ID string `json:"id,omitempty"` | ||
| Enabled bool `json:"enabled,omitempty"` | ||
| Type string `json:"type,omitempty"` | ||
| EndpointType string `json:"endpointType,omitempty"` | ||
| StreamEndpointUrl string `json:"streamEndpointUrl,omitempty"` | ||
| DataModelVersion string `json:"dataModelVersion,omitempty"` | ||
| TestMatch []StreamTestMatch `json:"testMatch,omitempty"` | ||
| TagMatch []StreamTagMatch `json:"tagMatch,omitempty"` | ||
| } |
There was a problem hiding this comment.
Was it intentional to omit these fields:
filtersexporterConfigcustomHeaders
| if sc.c.Limiter != nil { | ||
| sc.c.Limiter.Wait() | ||
| } | ||
| endpoint := sc.c.APIEndpoint + path + ".json" |
There was a problem hiding this comment.
We won't want the .json for v7
Suggested change
| endpoint := sc.c.APIEndpoint + path + ".json" | |
| endpoint := sc.c.APIEndpoint + path |
|
@ribejara-te @pcortada-te ^^ just in case you missed this. BTW @antonjim-te has some thoughts too to allow for traces in this too. |
antonjim-te
reviewed
Nov 6, 2024
| StreamEndpointUrl string `json:"streamEndpointUrl,omitempty"` | ||
| DataModelVersion string `json:"dataModelVersion,omitempty"` | ||
| TestMatch []StreamTestMatch `json:"testMatch,omitempty"` | ||
| TagMatch []StreamTagMatch `json:"tagMatch,omitempty"` |
There was a problem hiding this comment.
Suggested change
| TagMatch []StreamTagMatch `json:"tagMatch,omitempty"` | |
| TagMatch []StreamTagMatch `json:"tagMatch,omitempty"` | |
| Signal string `json:"signal,omitempty"` | |
| CustomHeaders map[string]string `json:"customHeaders,omitempty"` |
We are going to need them
signalto selected betweentraceandmetriccustomHeadersto add the authentication headers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.