bybit: Add OrderbookLastUpdated field and ensure timestamp usage is correct

[shazbert]

PR Description

• Use correct time fields for orderbook latency inspection

Fixes # (issue)

Type of change

Please delete options that are not relevant and add an x in [] as item is complete.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How has this been tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration and
also consider improving test coverage whilst working on a certain feature or package.

• go test ./... -race
• golangci-lint run
• Test X

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation and regenerated documentation via the documentation tool
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally and on Github Actions with my changes
• Any dependent changes have been merged and published in downstream modules

[gloriousCode]

Cool

[gloriousCode]

The only time I believe bybit sends pair data with delimiters is options
and we have this code at present:

for _, a := range []asset.Item{asset.CoinMarginedFutures, asset.USDTMarginedFutures, asset.USDCMarginedFutures, asset.Options} {
		if err := by.DisableAssetWebsocketSupport(a); err != nil {
			log.Errorln(log.ExchangeSys, err)
		}
	}

eg

[DEBUG] | WEBSOCKET | 08/11/2024 11:22:01 | Bybit wss://stream.bybit.com/v5/public/spot: Message received: {"topic":"orderbook.50.BTCUSDT","ts":1731025321625,"type":"delta","data":{"s":"BTCUSDT","b":[["76279.57","0.015295"],["76272.82","0.028297"],["76272.1","0"],["76271.98","0"]],"a":[["76293.07","0.015573"],["76298.47","0"]],"u":2491950,"seq":47455557170},"cts":1731025321618}

So unless you've seen otherwise, it can be set to false

[shazbert]

I can but its just going to switch back when #1670 gets merged and also the traversal doesn't add much in over head.

Still need me to do it?

[gloriousCode]

Isolating just the rune traversal, it adds roughtly 1ns per character. The longest spot pair is 10 characters, so I'm cool if you're cool with that extra per ws message. I would encourage you to consider something for that PR though (eg rather than true assetType == asset.Options) if only because silly ones like 10000000AIDOGEUSDT (2.5ns vs 21ns)

[shazbert]

fixed

[gloriousCode]

snak at tACK

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.05%. Comparing base (8fe909d) to head (9ddcfbd).
Report is 4 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1680      +/-   ##
==========================================
+ Coverage   36.95%   37.05%   +0.10%     
==========================================
  Files         414      414              
  Lines      180443   180305     -138     
==========================================
+ Hits        66677    66819     +142     
+ Misses     105923   105637     -286     
- Partials     7843     7849       +6     

Files with missing lines	Coverage Δ
exchanges/bybit/bybit_types.go	66.66% <ø> (ø)
exchanges/bybit/bybit_websocket.go	65.30% <100.00%> (+19.25%)	⬆️

... and 19 files with indirect coverage changes

[thrasher-]

Just one minor nit

[thrasher-]

Just noticed that the OB update is a snapshot rather than a delta, wasn't your doing but figured it can be fixed since PR relates to OB:

{"topic":"orderbook.50.BTCUSDT","type":"delta","ts":1687940967466,"data":{"s":"BTCUSDT","b":[["30247.20","30.028"],["30245.40","0.224"],["30242.10","1.593"],["30240.30","1.305"],["30240.00","0"]],"a":[["30248.70","0"],["30249.30","0.892"],["30249.50","1.778"],["30249.60","0"],["30251.90","2.947"],["30252.20","0.659"],["30252.50","4.591"]],"u":177400507,"seq":66544703342},"cts":1687940967464}

[shazbert]

fixed

[thrasher-]

Thanks for making those changes!