Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gateio: fix futures subscription generation #1725

Merged
merged 3 commits into from
Nov 25, 2024

Conversation

shazbert
Copy link
Collaborator

PR Description

Fixes issue [ERROR] | WEBSOCKET | 22/11/2024 08:56:38 | GateIO websocket: subscription failure, currency pairs is empty

Thanks @gbjk for bringing this up.

Type of change

Please delete options that are not relevant and add an x in [] as item is complete.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration and
also consider improving test coverage whilst working on a certain feature or package.

  • go test ./... -race
  • golangci-lint run
  • Test X

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation and regenerated documentation via the documentation tool
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally and on Github Actions with my changes
  • Any dependent changes have been merged and published in downstream modules

@shazbert shazbert added bug review me This pull request is ready for review labels Nov 24, 2024
@shazbert shazbert requested a review from a team November 24, 2024 03:18
@shazbert shazbert self-assigned this Nov 24, 2024
exchanges/gateio/gateio_ws_futures.go Outdated Show resolved Hide resolved
exchanges/gateio/gateio_ws_futures.go Outdated Show resolved Hide resolved
exchanges/gateio/gateio_ws_futures.go Outdated Show resolved Hide resolved
exchanges/gateio/gateio_ws_futures.go Outdated Show resolved Hide resolved
exchanges/gateio/gateio_ws_futures.go Outdated Show resolved Hide resolved
exchanges/gateio/gateio_ws_futures.go Outdated Show resolved Hide resolved
@gbjk
Copy link
Collaborator

gbjk commented Nov 24, 2024

Good work 👏
Just a few minor things.

@shazbert shazbert requested a review from gbjk November 24, 2024 22:35
Copy link
Collaborator

@gloriousCode gloriousCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, what actually caused the issue so that I may replicate/verify that things are fixed?
edit:
Replication Steps:

  1. Disable all GateIO assets except futures
  2. Only have BTC-USD as the enabled pair
  3. Run GCT

Copy link
Collaborator

@gloriousCode gloriousCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK! Thank you!

It does show the following output now that things are fixed though. I kinda dislike the output and I'll think about how to whinge about this in future 🌈

if verbose
log.Warnf(log.WebsocketMgr, "%s websocket: no subscriptions generated", w.exchangeName)

Copy link
Collaborator

@thrasher- thrasher- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both:
image

just BTC-USD enabled:
image

tACK, thanks @gbjk for reporting this!

@thrasher- thrasher- merged commit 3b2b15e into thrasher-corp:master Nov 25, 2024
5 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug review me This pull request is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants