-
Notifications
You must be signed in to change notification settings - Fork 812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gateio: fix futures subscription generation #1725
Conversation
Good work 👏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, what actually caused the issue so that I may replicate/verify that things are fixed?
edit:
Replication Steps:
- Disable all GateIO assets except futures
- Only have BTC-USD as the enabled pair
- Run GCT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK! Thank you!
It does show the following output now that things are fixed though. I kinda dislike the output and I'll think about how to whinge about this in future 🌈
if verbose
log.Warnf(log.WebsocketMgr, "%s websocket: no subscriptions generated", w.exchangeName)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Description
Fixes issue
[ERROR] | WEBSOCKET | 22/11/2024 08:56:38 | GateIO websocket: subscription failure, currency pairs is empty
Thanks @gbjk for bringing this up.
Type of change
Please delete options that are not relevant and add an
x
in[]
as item is complete.How has this been tested
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration and
also consider improving test coverage whilst working on a certain feature or package.
Checklist