Skip to content

Commit

Permalink
InstancedMesh, BatchedMesh docs: clarify lack of negatively scaled ma…
Browse files Browse the repository at this point in the history
…trix support
  • Loading branch information
Methuselah96 committed Jan 26, 2025
1 parent 16dcaf7 commit e6a9eab
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
1 change: 1 addition & 0 deletions types/three/src/objects/BatchedMesh.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,7 @@ declare class BatchedMesh extends Mesh<BufferGeometry, Material> {

/**
* Sets the given local transformation matrix to the defined instance.
* Negatively scaled matrices are not supported.
* @param instanceId The id of an instance to set the matrix of.
* @param matrix A 4x4 matrix representing the local transformation of a single instance.
*/
Expand Down
7 changes: 4 additions & 3 deletions types/three/src/objects/InstancedMesh.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -145,9 +145,10 @@ export class InstancedMesh<
getMorphAt(index: number, mesh: Mesh): void;

/**
* Sets the given local transformation matrix to the defined instance.
* @remarks
* Make sure you set {@link InstancedBufferAttribute.needsUpdate | .instanceMatrix.needsUpdate()} flag to `true` after updating all the matrices.
* Sets the given local transformation matrix to the defined instance. Make sure you set
* {@link InstancedBufferAttribute.needsUpdate | .instanceMatrix.needsUpdate()} flag to `true` after updating all
* the matrices.
* Negatively scaled matrices are not supported.
* @param index The index of an instance. Values have to be in the range `[0, count]`. Expects a `Integer`
* @param matrix A 4x4 matrix representing the local transformation of a single instance.
*/
Expand Down

0 comments on commit e6a9eab

Please sign in to comment.