Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Umbrel v1.2.2 #311

Open
wants to merge 6 commits into
base: development
Choose a base branch
from
Open

Umbrel v1.2.2 #311

wants to merge 6 commits into from

Conversation

PeterNashaat
Copy link
Member

  • Updating Umbrel to latest version.

@PeterNashaat PeterNashaat mentioned this pull request Oct 31, 2024
Closed
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 31, 2024
View reviewed changes
tfgrid3/umbrel/app/Dockerfile
@@ -0,0 +1,92 @@
FROM --platform=$BUILDPLATFORM debian:bookworm-slim AS base

Check failure

Code scanning / Trivy

Image user should not be 'root' High

Artifact: tfgrid3/umbrel/app/Dockerfile
Type: dockerfile
Vulnerability DS002
Severity: HIGH
Message: Specify at least 1 USER command in Dockerfile with non-root user as argument
Link: DS002
@hossnys
Copy link
Collaborator

hossnys commented Jan 12, 2025

please fix that recommendation of Trivy for --no-install-recommends and -y flags to avoid needing for manual interaction , then we can approve , and then ask for flist promotion .

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 14, 2025
View reviewed changes
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 14, 2025
View reviewed changes
tfgrid3/umbrel/flist/Dockerfile
@@ -0,0 +1,24 @@
FROM ubuntu:22.04

Check failure

Code scanning / Trivy

Image user should not be 'root' High

Artifact: tfgrid3/umbrel/flist/Dockerfile
Type: dockerfile
Vulnerability DS002
Severity: HIGH
Message: Specify at least 1 USER command in Dockerfile with non-root user as argument
Link: DS002
@mik-tf
Copy link
Contributor

mik-tf commented Feb 11, 2025 •
edited
Loading

As I understand, this can be merged, since the Trivy error is because the Dockerfile is built for root, which is not a problem with the way we work.

I suggest we remove this root-check as it's never needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hossnys hossnys hossnys approved these changes

@coesensbert coesensbert coesensbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PeterNashaat @hossnys @mik-tf @coesensbert