disable output styling for cli and tfrobot #1242
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eslam-Nawara
force-pushed
the
development-disable-output-styling-cli
branch
from
66382ad to
4f0a1ac
Compare
Eslam-Nawara
requested review from
mariobassem,
ashraffouda,
rawdaGastan,
Omarabdul3ziz,
AbdelrahmanElawady,
xmonader and
sameh-farouk
as code owners
|
Can you update the pr with the difference? |
|
here I loaded a deployment with and without --no-color flag ➜ grid-cli git:(development-disable-output-styling-cli) ✗ go run main.go get vm test &> output1
➜ grid-cli git:(development-disable-output-styling-cli) ✗ go run main.go get vm test --no-color &> output2
and as the issue specifies the output is wrapped in escape sequences, so I added an option to disable that if the user need to get the values without wrapping them |
Eslam-Nawara
force-pushed
the
development-disable-output-styling-cli
branch
from
fed0485 to
3801121
Compare
rawdaGastan
requested changes
Jan 27, 2025
| @@ -17,12 +17,26 @@ var getContractCmd = &cobra.Command{ | |||
| Use: "contract", | |||
| Short: "Get twin contract", | |||
| Run: func(cmd *cobra.Command, args []string) { | |||
| noColor, err := cmd.Flags().GetBool("no-color") | |||
| if err != nil { | |||
| return | |||
There was a problem hiding this comment.
How would I know the error here? check other files
| @@ -50,4 +64,5 @@ var getContractCmd = &cobra.Command{ | |||
|
|
|||
| func init() { | |||
| getCmd.AddCommand(getContractCmd) | |||
| getContractCmd.Flags().Bool("no-color", false, "disable output styling") | |||
There was a problem hiding this comment.
why not adding it to the parent command instead of adding it for every subcommand?
| return fmt.Errorf("invalid log debug mode input '%v' with error: %w", debug, err) | ||
| } | ||
|
|
||
| zerolog.SetGlobalLevel(zerolog.InfoLevel) |
| log.Error().Msg("deployments failed with errors: ") | ||
| fmt.Println(errs) | ||
| os.Exit(1) | ||
| if errs := deployer.RunDeployer(context.Background(), cfg, tfPluginClient, outputPath, debug); errs != nil { |
There was a problem hiding this comment.
why not taking command ctx?
| log.Error().Msg("failed to load configured deployments") | ||
| fmt.Println(err) | ||
| os.Exit(1) | ||
| if err := deployer.RunLoader(context.Background(), cfg, tfPluginClient, debug, outputPath); err != nil { |
There was a problem hiding this comment.
same here, why not using command ctx?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add flag to disable output styling for cli and tfrobot
Related Issues
Checklist