Update setup.py to Python 3.4+ Compatible #1099
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the Python documentation, the imp library is "deprecated since version 3.4: The imp package is pending deprecation in favor of importlib." That's why I replace the imp call with importlib to make it compatible with Python higher than 3.4. I'm proposing this, because I went into issue building the darkflow with Python 3.5.1 or higher. Hope this would help others who encountered the same issue. =] Further info about imp, refer to the Python Documentation below: https://docs.python.org/3/library/imp.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the Python documentation, the imp library is "deprecated since version 3.4: The imp package is pending deprecation in favor of importlib." That's why I replace the imp call with importlib to make it compatible with Python higher than 3.4.
I'm proposing this, because I went into issue building the darkflow with Python 3.7.x and 3.8. Hope this would help others who encountered the same issue. =]
Further info about imp, refer to the Python Documentation below:
https://docs.python.org/3/library/imp.html