Update and fix dependencies related to mac install #1044
Conversation
README.md
Outdated
| - `robotics` (for gymnasium-robotics environments) | ||
| - `vizdoom` (for ViZDoom environments) | ||
| - `envpool` (for envpool integration) | ||
| - `dev` (for development requirements) |
There was a problem hiding this comment.
Isn't that a group rather than an extra?
There was a problem hiding this comment.
If you're referring to 'dev', then you're right. 'robotics' and 'vizdoom' should be extras (in the same fashion as 'atari' and 'mujoco' before). Should I just remove it from readme?
There was a problem hiding this comment.
Yes, just dev. Feel free to include it separately in the readme if not done yet, as groups are installed with a different command (not --extras)
| @@ -60,13 +60,22 @@ def __init__(self, env, action_repeat=3, reward_scale=5, rm_done=True): | |||
| def step(self, action): | |||
| rew_sum = 0.0 | |||
| for _ in range(self.action_repeat): | |||
| obs, rew, done, info = self.env.step(action) | |||
| step_result = self.env.step(action) | |||
| if len(step_result) == 4: | |||
There was a problem hiding this comment.
This should never happen, we use gymnasium envs, not (older) gym envs. How did you run into this?
There was a problem hiding this comment.
Note that if it needs fixing in one example, it will need fixing in all of them :(
There was a problem hiding this comment.
I guess it was some older example that noone touched in a while. The check for old vs new api is still present in atari_wrapper.py, that's where I just copied it from. You're right though, the Collector assumes terminated and truncated coming from env.step, I'll just delete this part
examples/mujoco/fetch_her_ddpg.py
Outdated
| @@ -96,6 +95,8 @@ def test_ddpg(args=get_args()): | |||
|
|
|||
| # logger | |||
| if args.logger == "wandb": | |||
| import wandb | |||
There was a problem hiding this comment.
If you do it here, you need to do it everywhere. I thought wandb was not an optional dependency, am I wrong?
There was a problem hiding this comment.
I checked, it's the only example where wandb is import. I also thought about removing it since wandb currently is only part of the 'dev' group dependencies
# Conflicts: # examples/box2d/bipedal_bdq.py # examples/box2d/bipedal_hardcore_sac.py
…install # Conflicts: # README.md
|
Thank you, now only a final testing on windows and ubuntu is needed, and #1015 can be resolved. Merging this when the pipeline passed |
Addresses part of #1015
Dependencies
Mac specific
Other