New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw exception when DB_SWITCH is invalid #377

Merged

OneSizeFitsQuorum merged 1 commit into thulab:master from liyuheng55555:012_is_so_evil

Oct 18, 2023

Collaborator

liyuheng55555 commented Oct 18, 2023

Now if db_switch is invalid, benchmark will use 012 as default. This is bad for debugging.
So, throw an exception instead.


          don't use 012, throw exception instead

ae068f4

OneSizeFitsQuorum approved these changes

View reviewed changes

Contributor

OneSizeFitsQuorum left a comment

LGTM

liyuheng55555 changed the title ~~Don't use 012 as default !~~ Throw exception when DB_SWITCH is invalid

OneSizeFitsQuorum merged commit 2bfce9c into thulab:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet